Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add behaviour test step definition for retrieving the currently connected user #413

Merged
merged 4 commits into from
Apr 30, 2023
Merged

Add behaviour test step definition for retrieving the currently connected user #413

merged 4 commits into from
Apr 30, 2023

Conversation

jamesreprise
Copy link
Contributor

@jamesreprise jamesreprise commented Apr 27, 2023 •
edited
Loading

What is the goal of this PR?

We've added a behaviour test step get connected user in line with changes made in typedb/typedb-behaviour#247

What are the changes implemented in this PR?

Added user step: get connected user.

@jamesreprise jamesreprise self-assigned this Apr 27, 2023
@typedb-bot
Copy link
Member

typedb-bot commented Apr 27, 2023 •
edited by flyingsilverfin
Loading

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@jamesreprise jamesreprise changed the title Add behaviour test step definition for the user getting themself Add behaviour test step definition for retrieving the currently connected user Apr 27, 2023
flyingsilverfin
flyingsilverfin reviewed Apr 30, 2023
View reviewed changes
test/behaviour/connection/user/UserSteps.java Outdated
@@ -47,6 +47,11 @@ public boolean user_is_in_users(String username) {
return users.contains(username);
}

@Then("get connected user")
public void users_get() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_connected_user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Done.

@flyingsilverfin flyingsilverfin merged commit d37243a into typedb:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyingsilverfin flyingsilverfin flyingsilverfin approved these changes

@alexjpwalker alexjpwalker Awaiting requested review from alexjpwalker

@haikalpribadi haikalpribadi Awaiting requested review from haikalpribadi

Assignees

@haikalpribadi haikalpribadi

@alexjpwalker alexjpwalker

@jamesreprise jamesreprise

Labels
priority: medium type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamesreprise @typedb-bot @flyingsilverfin @haikalpribadi @alexjpwalker