Store error on transaction stream #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
changed the title
flyingsilverfin
commented
Jan 21, 2022
| else { | ||
| state = State.EMPTY; | ||
| return next; | ||
| } |
There was a problem hiding this comment.
we make the next() idempotently throw the same error if the user repeatedly calls it
flyingsilverfin
commented
Jan 21, 2022
| @@ -108,6 +111,7 @@ public void close() { | |||
|
|
|||
| private void close(@Nullable StatusRuntimeException error) { | |||
| if (isOpen.compareAndSet(true, false)) { | |||
| this.error = error; | |||
There was a problem hiding this comment.
store the closure error against the bidirectional stream to prevent future transaction operations
alexjpwalker
approved these changes
Jan 21, 2022
lolski
pushed a commit
that referenced
this pull request
Mar 14, 2022
## What is the goal of this PR? We revert previous changes from #368 and #364, which made query queues and iterators throw the same error idempotently if there was one. However, this goes counter to standard usages of iterators and queues, which are not meant to behave idempotently (each item is only returned once, and if they have an error they should no longer be used). ## What are the changes implemented in this PR? * remove idempotent error state of collectors and queues, which back query iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We store any exceptions received against the transaction stream (as well as query streams) in order to propagate the error to any future transaction operations, not just open query streams.
What are the changes implemented in this PR?