[Python Driver] client.close() doesn't appear to work #669
Assignees
Labels
Comments
|
You're totally correct, it is a bug in our logic. Moreover, it indicates a hole in our tests! I've created an issue for behaviour tests to prevent it from happening in the future, and I'll add an integration test for this driver with the fix. |
farost
added a commit
that referenced
this issue
Jul 5, 2024
…ing for both core and cloud (#670) ## Usage and product changes We fix the issue #669, where the Python Driver didn't close the connection when calling `TypeDBDriver.close()`. ## Implementation We needed to reverse the condition of `is_open()`. The main issue is the absence of tests for our drivers' connections, so we: * add new integration tests for both core and cloud; * create an issue for behaviour tests to cover this hole for a brighter future: typedb/typedb-behaviour#289.
|
Thanks for noticing it! The fix for this issue will be a part of the next release (hopefully by the end of the next week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/vaticle/typedb-driver/blob/6cfb17d2561f5d6f17aeecf8d14592ef22874572/python/typedb/connection/driver.py#L96
shouldn't this line be
if self.is_open()instead ofif not self.is_open()?Otherwise if you run
client.close()followed byclient.is_open()it still shows the client as being open... effectivelyclient.close()isn't doing anything right now as far as I can tell.The text was updated successfully, but these errors were encountered: