Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases for TypeDBOptions #202

Open
alexjpwalker opened this issue Dec 11, 2020 · 1 comment
Open

Test cases for TypeDBOptions #202

alexjpwalker opened this issue Dec 11, 2020 · 1 comment
Labels
priority: medium type: feature
Milestone
TypeDB Client: Ru...

Comments

@alexjpwalker
Copy link
Member

alexjpwalker commented Dec 11, 2020 •
edited
Loading

Problem to Solve

Since moving to a reliance on BDD, TypeDBOptions are largely untested in 2.0.

Current Workaround

Manual testing / integration testing

Proposed Solution

Create BDD scenarios and implement them in all clients

Additional information

Some options are only relevant to queries over RPC (eg batch size) so it doesn't really make sense to include test runners for these options in the Grakn server itself.

Also, some options were tested in client-python in 1.8, and these test scenarios can be salvaged from test_grakn.py in the client-python repo.
@alexjpwalker alexjpwalker changed the title Test cases for GraknOptions Test cases for TypeDBOptions Nov 2, 2021
@alexjpwalker alexjpwalker modified the milestone: Technical Debt Nov 2, 2021
@flyingsilverfin
Copy link
Member

Note: we have implemented a basic test for options in #364

dmitrii-ubskii pushed a commit to dmitrii-ubskii/typedb-driver that referenced this issue Aug 31, 2023
@flyingsilverfin
Store error on transaction stream and clean up completed query state (t…
b0c26fe 
…ypedb#202)

## What is the goal of this PR?

Multiplexed query streams over the transaction stream are cleaned up when complete. We also store any exceptions received against the transaction stream (as well as query streams) in order to propagate the error to any future transaction operations, not just open query streams.

## What are the changes implemented in this PR?

* Remove single and iterator response queues when they are finished
* store errors against query streams and transaction streams, so we can error on transaction operations against a closed transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium type: feature
Projects
None yet
Milestone
TypeDB Client: Rust Rewrite
Development

No branches or pull requests
3 participants
@haikalpribadi @flyingsilverfin @alexjpwalker