Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bump protobuf #271

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Bump protobuf #271

merged 3 commits into from
Dec 5, 2022

Conversation

jamesreprise
Copy link
Contributor

What is the goal of this PR?

We've bumped our protobuf dependency in response to the following issue:

What are the changes implemented in this PR?

We've changed our pinned protobuf version from 3.15.5 to 3.20.1.

@typedb-bot
Copy link
Member

typedb-bot commented Dec 5, 2022

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin merged commit c4d6085 into typedb:master Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants