Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement //ci:release-validate-deps #95

Merged
merged 4 commits into from
Sep 23, 2019

Conversation

lolski
Copy link
Member

@lolski lolski commented Sep 23, 2019

The //ci:release-validate-deps can be used from the CI job to ensure that we're depending on a release instead of a snapshot dependency.

For example, if we are to release graknlabs_grakn_core which depends on a snapshot version of graknlabs_common will fail with the following error message:

bazel run @graknlabs_build_tools//ci:release-validate-deps graknlabs_graql graknlabs_common

RuntimeError: This commit is not releasable because there are one or more snapshot 
dependencies: ['graknlabs_common']. Check that every dependencies listed in 
dependencies/graknlabs/dependencies.bzl are all release dependencies 
(ie., depends on a tag instead of a commit).

If every dependency is a release dependency, it will succeed:

bazel run @graknlabs_build_tools//ci:release-validate-deps graknlabs_graql graknlabs_common

This repository is releasable because the dependencies
are all release dependencies: ['graknlabs_common', 'graknlabs_graql']

@lolski lolski requested review from vmax and removed request for haikalpribadi September 23, 2019 14:43
ci/release-validate-deps.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vmax vmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved w minor comments

@lolski lolski merged commit 64517da into typedb:master Sep 23, 2019
@lolski lolski deleted the release-validate-deps branch September 23, 2019 15:41
@vmax vmax mentioned this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants