Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test: connected user can be retrieved #247

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Add test: connected user can be retrieved #247

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
455159d
feat: add test: user can get themselves
Apr 27, 2023
04973b8
feat: get connected user
Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions connection/user.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ Feature: Connection Users
Given users delete: user
Then users not contains: user

Scenario: users can get themselves
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not really in our 'style' grammatically? Bit informal - try calling this 'connected user is retrievable' and call the step 'Then get connected user' instead of 'user get self'?

Copy link
Contributor Author

@jamesreprise jamesreprise Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, done.

Given typedb starts
Given connection opens with authentication: admin, password
When users create: user, password
Then connection closes
Given connection opens with authentication: user, password
Then user get self

@ignore-typedb-client-python @ignore-typedb-client-nodejs
Scenario: user passwords must comply with the minimum length
Given typedb has configuration
Expand Down