Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspace_refs optional for assemble_maven #182

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Make workspace_refs optional for assemble_maven #182

merged 1 commit into from
Sep 23, 2019

Conversation

vmax
Copy link
Contributor

@vmax vmax commented Sep 23, 2019

What is the goal of this PR?

Fix #176
assemble_maven should support a scenario where workspace_refs is not provided by users

What are the changes implemented in this PR?

  • Default to empty workspace_refs if no file is provided

@vmax vmax merged commit 0065b12 into typedb:master Sep 23, 2019
@vmax vmax deleted the optional-workspace-refs branch September 23, 2019 15:58
vmax added a commit to typedb/typedb-dependencies that referenced this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assemble_maven should not require workspace_refs
2 participants