-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- We remove the `skipIfSigned` functionality from the `AppleCodeSigner` - We add verbose logging to `xcrun` calls if it is enabled We've concluded that it is not the responsibility of a maintainer of an open-source library to sign their code for MacOS installers, as such we want to sign these packages ourselves. This may cause us to assume responsibility for issues in our application caused by these packages; this seems reasonable. We have previously encountered issues when releasing `typedb-studio` due to a package that was signed, but not specifically for MacOS installers, failing Apple's checks. As such, we want to sign *all* packages captured by our `deepSignJarsRegex` - not just unsigned ones. This ensures that all signatures are valid. However, we still value the `deepSignJarsRegex` to avoid unnecessarily unpackaging and re-signing every single jar we depend on. We remove the `skipIfSigned` argument and the functionality gated behind it. We also fix an issue where the `verbose` logging flag was not being correctly propagated to our code signing commands.
- Loading branch information
1 parent
425493c
commit a44871f
Showing
4 changed files
with
32 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters