Safe match inserts #67

flyingsilverfin · 2022-10-21T12:48:20Z

What is the goal of this PR?

We validate that match-inserts only match 1 answer before doing inserts. This is disableable with a new flag --allowMultiInserts

Fix a bunch of tests that relied on toString() for equality checks on TypeQL insert queries
Verify that match-inserts only receive 1 match answer before doing inserts. We rewrite match-insert with constraints into a match using IIDs or Labels to do avoid doing the complex match multiple times

ChandraReddy97 · 2022-11-01T14:45:47Z

@flyingsilverfin change variable name from --allowMultiInserts to --allowMultiInsert

flyingsilverfin added 3 commits October 21, 2022 11:59

Check match before doing insert

b226d0c

edit test

b264f0d

pass test by hacking a solutioN

da285b7

flyingsilverfin requested a review from hkuich October 21, 2022 12:48

bump version to 1.5.0

90f9770

flyingsilverfin merged commit 1ffae11 into typedb-osi:master Oct 21, 2022

flyingsilverfin deleted the safe-match-inserts branch October 21, 2022 12:51