Bring apps closer to typechecking out of the box #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
commented
Jul 1, 2020
| @@ -146,8 +146,8 @@ module.exports = { | |||
| { name: 'ember-cli-typescript-blueprints', target: 'latest' }, | |||
| { name: 'typescript', target: 'latest' }, | |||
| { name: '@types/ember', target: 'latest' }, | |||
| { name: '@types/rsvp', target: 'latest' }, | |||
There was a problem hiding this comment.
@types/ember already brings in @types/rsvp, and having one fewer explicit version constraint floating around makes "cannot re-declare block scoped variables" less likely to crop up as folks update various dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, if I run
ember new my-appand then immediately follow that withember install ember-cli-typescript, I can almost renameapp.js,router.jsandtest-helper.jsto end in.tsand have a typechecking application out of the box. There are still just a couple of blockers for that:app.jsimportsember-resolverbut we don't install the@typespackage for that by defaulttest-helper.jsreferencesconfig.APP, which isn't part of the declarations we emit forconfig/environmenttest-helper.jsincludes relative imports forappandconfig/environmentthat work at runtime but don't match the on-disk layout, so TS rejects the importThis PR aims to fix those first two bullets, and I have an ember-cli PR open to address the third.