Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@types/ember bug] - @ember/instrumentation private package should not be exposed through types #289

Closed
1 task done
mike-north opened this issue Sep 11, 2018 · 1 comment
Closed
1 task done

[@types/ember bug] - @ember/instrumentation private package should not be exposed through types #289

mike-north opened this issue Sep 11, 2018 · 1 comment
Assignees
@mike-north
Labels
bug types:core Something is wrong with the Ember type definitions

Comments

@mike-north
Copy link
Contributor

Which package(s) does this problem pertain to?

  • @types/ember

What are instructions we can follow to reproduce the issue?

import * as X from '@ember/instrumentation'

Now about that bug. What did you expect to see?

A type error. This is a private package, we should not expose that the module even exists

What happened instead?

No type errors
@mike-north mike-north mentioned this issue Sep 11, 2018
Closed
@mike-north mike-north added bug types:core Something is wrong with the Ember type definitions labels Sep 12, 2018
@mike-north mike-north self-assigned this Sep 15, 2018
mike-north added a commit to mike-north/DefinitelyTyped that referenced this issue Sep 15, 2018
@mike-north
[ember] do not expose private @ember/instrumentation package
d61274d 
- fixes typed-ember/ember-cli-typescript#289
@mike-north
Copy link
Contributor Author

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-north mike-north

Labels
bug types:core Something is wrong with the Ember type definitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mike-north