Skip to content

Commit

Permalink
Update GH actions and lint/format
Browse files Browse the repository at this point in the history
  • Loading branch information
tyom committed Oct 3, 2023
1 parent 29899d8 commit e5ac6a9
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 20 deletions.
17 changes: 11 additions & 6 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,21 @@ jobs:
name: build and test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16

- uses: pnpm/action-setup@v2
name: Install pnpm
with:
version: 8

- name: Install dependencies
run: yarn install --frozen-lockfile
run: pnpm install

- name: Lint source
run: yarn lint
run: pnpm lint

- name: Build app and generate PDF
run: yarn predeploy
run: pnpm predeploy
22 changes: 15 additions & 7 deletions .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,26 @@ jobs:
name: build and deploys
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16

- uses: pnpm/action-setup@v2
name: Install pnpm
with:
version: 8

- name: Install dependencies
run: yarn install --frozen-lockfile
run: pnpm install

- name: Lint source
run: pnpm lint

- name: Build app and Storybook and prepare for deployment
run: yarn predeploy
- name: Build app and generate PDF
run: pnpm predeploy
env:
GA_TRACKING_ID: UA-332655-6
PUBLIC_GA_MEASUREMENT_ID: G-T41297TYQ1

- name: Deploy to GH Pages
uses: peaceiris/actions-gh-pages@v3
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ build/**
node_modules/**
dist/
storybook-static/
pnpm-lock.yaml
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ The static site is deployed to GH Pages. To deploy manually (this also runs pred

## Environment variables

| Variable | Description |
|:-------------------------|:-----------------------------------------|
| GIT_USER_EMAIL | Git user email for pushing to GH pages |
| GIT_USER_NAME | Git user name for pushing to GH pages |
| PUBLIC_GA_MEASUREMENT_ID | Google Analytics measuremet ID |
| Variable | Description |
| :----------------------- | :------------------------------------- |
| GIT_USER_EMAIL | Git user email for pushing to GH pages |
| GIT_USER_NAME | Git user name for pushing to GH pages |
| PUBLIC_GA_MEASUREMENT_ID | Google Analytics measuremet ID |
3 changes: 1 addition & 2 deletions src/app.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
href="https://fonts.googleapis.com/css?family=Roboto:400,700"
rel="stylesheet"
/>
%sveltekit.head%
%unocss-svelte-scoped.global%
%sveltekit.head% %unocss-svelte-scoped.global%
</head>
<body>
<div id="container">%sveltekit.body%</div>
Expand Down
1 change: 1 addition & 0 deletions src/components/ExperienceItem.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
</header>
{#if description}
<div class="description">
<!-- eslint-disable-next-line svelte/no-at-html-tags -->
{@html description}
</div>
{/if}
Expand Down
2 changes: 2 additions & 0 deletions src/components/Summary.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<h1 class="font-bold tracking-wide leading-none text-[2.9em]">{name}</h1>
<h2 class="leading-none opacity-60 text-[1.4em]">{title}</h2>
<div class="max-w-[68ch] leading-snug">
<!-- eslint-disable-next-line svelte/no-at-html-tags -->
{@html details}
</div>
<section class="divided">
Expand Down Expand Up @@ -93,6 +94,7 @@
<div class="space-y-1">
<dt class="sr-only">{type}</dt>
<dd>
<!-- eslint-disable-next-line svelte/no-at-html-tags -->
{@html details}
</dd>
</div>
Expand Down

0 comments on commit e5ac6a9

Please sign in to comment.