fix(tests): Remove unnecessary test

Testing that a bad completion directive was being replaced by the default one was actually testing Cobra's behaviour. This is unnecessary especially since that behaviour changed in the 1.2.0 release. Helm tests should focus on testing Helm's behaviour. Signed-off-by: Marc Khouzam <[email protected]>
tylerauerbeck · Aug 5, 2021 · 28f919b · 28f919b
1 parent a4b4a3c
commit 28f919b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/cmd/helm/plugin_test.go b/cmd/helm/plugin_test.go
@@ -277,11 +277,6 @@ func TestPluginDynamicCompletion(t *testing.T) {
 		cmd:    "__complete echo -n mynamespace ''",
 		golden: "output/plugin_echo_no_directive.txt",
 		rels:   []*release.Release{},
-	}, {
-		name:   "completion for plugin bad directive",
-		cmd:    "__complete echo ''",
-		golden: "output/plugin_echo_bad_directive.txt",
-		rels:   []*release.Release{},
 	}}
 	for _, test := range tests {
 		settings.PluginsDirectory = "testdata/helmhome/helm/plugins"

diff --git a/cmd/helm/testdata/helmhome/helm/plugins/echo/plugin.complete b/cmd/helm/testdata/helmhome/helm/plugins/echo/plugin.complete
@@ -7,8 +7,7 @@ echo "Args received: ${@}"
 
 # Final printout is the optional completion directive of the form :<directive>
 if [ "$HELM_NAMESPACE" = "default" ]; then
-    # Output an invalid directive, which should be ignored
-    echo ":2222"
+    echo ":0"
 # else
     # Don't include the directive, to test it is really optional
 fi
diff --git a/cmd/helm/testdata/output/plugin_echo_bad_directive.txt b/cmd/helm/testdata/output/plugin_echo_bad_directive.txt