Merge pull request mui#1610 from garth/fix-select-field-onchange

SelectField now triggers on change consistently when using props.value
tyfoo · Nov 10, 2015 · db23297 · db23297
2 parents 2a16e58 + 8ec1fcf
commit db23297
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/drop-down-menu.jsx b/src/drop-down-menu.jsx
@@ -316,12 +316,12 @@ const DropDownMenu = React.createClass({
   },
 
   _onMenuItemClick(e, key, payload) {
-    if (this.props.onChange && this.state.selectedIndex !== key) {
-      let selectedItem = this.props.menuItems[key];
-      if (selectedItem) {
-        e.target.value = selectedItem[this.props.valueMember];
-      }
+    let selectedItem = this.props.menuItems[key];
+    if (selectedItem) {
+      e.target.value = selectedItem[this.props.valueMember];
+    }
 
+    if (this.props.onChange && (this.state.selectedIndex !== key || e.target.value !== this.props.value)) {
       if (this.props.valueLink) {
         this.props.valueLink.requestChange(e.target.value);
       }