Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus]: Add path metric per host #250

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

erbesharat
Copy link
Member

What this PR does / why we need it:
Adds path metric per host

Which issue this PR fixes:
fixes #174

@erbesharat
Copy link
Member Author

Tests failed once but passed after I restarted the job.
Cause of failure:

go: golang.org/x/[email protected]: git -c protocol.version=0 fetch --unshallow -f https://go.googlesource.com/net refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /go/pkg/mod/cache/vcs/4a22365141bc4eea5d5ac4a1395e653f2669485db75ef119e7bbec8e19b12a21: exit status 128:
  error: Could not read ab5485076ff3407ad2d02db054635913f017b0ed
  fatal: Failed to traverse parents of commit 44b7c21cbf19450f38b337eb6b6fe4f6496fb5b3
  error: remote did not send all necessary objects
go: error loading module requirements

Not sure but this might help or at least give us some info: golang/go#26594

@stp-ip
Copy link
Member

stp-ip commented Mar 13, 2019

Looks good. Will merge and we can see, how that makes our metrics more complex and more resource intensive.
Sidenote: Always happy for you to also join discussions on the issues before implementing one of the solutions. Discussion is great to get to know different viewpoints that I and others might have missed.

@stp-ip stp-ip merged commit 8774437 into txtdirect:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus] Discuss adding path metric per host
2 participants