Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document new features in v1.2 #171

Merged
merged 6 commits into from
Mar 1, 2022
Merged

docs: Document new features in v1.2 #171

merged 6 commits into from
Mar 1, 2022

Conversation

scarmuega
Copy link
Member

No description provided.

@rvcas
Copy link
Member

rvcas commented Mar 1, 2022

https://github.com/txpipe/oura/blob/main/book/src/sources/n2n.md?plain=1#L42

Since there are some docs being updated, I think this section linked above has a small mistake. Both sentences say unix socket but both config examples use "Tcp". If I understand things correctly, shouldn't one of the sentences be switched to say tcp and one of the examples switch to use Unix?

Another thing I noticed is here: https://github.com/txpipe/oura/blob/main/book/src/sources/n2c.md?plain=1#L3

The first sentence says unix socket bearer but both n2n/n2c seem to support Tcp or Unix according to the rust types.

@scarmuega scarmuega merged commit aee714f into main Mar 1, 2022
@scarmuega scarmuega deleted the docs/new-v1.2 branch March 1, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants