Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument for ecdh_curve #133

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add argument for ecdh_curve #133

merged 2 commits into from
Oct 11, 2023

Conversation

tyr84
Copy link
Contributor

@tyr84 tyr84 commented Oct 11, 2023

Add the ability to specify ecdh_curve at runtime, see discussion in #121

@twrecked
Copy link
Owner

Thanks for this.

One comment, when you print the curve being used can you convert it to a self.debug.

@twrecked twrecked merged commit 5bce05b into twrecked:master Oct 11, 2023
@twrecked
Copy link
Owner

Merged. Again, thanks for this!

@tyr84
Copy link
Contributor Author

tyr84 commented Oct 12, 2023

One comment, when you print the curve being used can you convert it to a self.debug.

Yep, print was only intended for local test, therefore removed at cleanup.

The original design idea was to have pyaarlo switch curves during retries. But it seems to me the retry logic is handled by cloudscraper, or even requests? Couldn't find retry-logic in your repo..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants