Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Xcode 15 localization #181

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Xcode 15 localization #181

wants to merge 2 commits into from

Conversation

Harry-KNIGHT
Copy link
Contributor

Use Xcode 15 localization for have all localized into one file and translate this big open source project to a larger audience of developers

@twostraws
Copy link
Owner

Hello! Thank you for this – it's an important step forward. Before I merge, I just want to check why we're using NSLocalizedString. As this project is written almost entirely in SwiftUI, I'm rather hopeful we get automatic localization through the framework.

@Harry-KNIGHT
Copy link
Contributor Author

Hello! Thank you for this – it's an important step forward. Before I merge, I just want to check why we're using NSLocalizedString. As this project is written almost entirely in SwiftUI, I'm rather hopeful we get automatic localization through the framework.

@twostraws be careful, do not merge at this MR step, I opened it as draft for you can see my proposal, if this way of doing it is okay for you I will make it for all text and localized already existing.

If you have any advices I'll take them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khalilheyrani6367 Khalilheyrani6367 Khalilheyrani6367 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harry-KNIGHT @twostraws @Khalilheyrani6367