feat: turn methods private and fix text moving depending on number te… #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twostraws what's the convention about indentation ? I think I made something wrong on this MR so much code where touched by indentation after 
I Changed indent using Spaces it fixed it. |
…xt from slider feat: change indentation to spacebar
Harry-KNIGHT
force-pushed
the
feature/text-not-moving-when-sliding
branch
from
efcac1b
to
9a37f74
Compare
|
Thank you! Regarding spacing etc, ideally the issue should be flagged up by SwiftLint, but if it isn't we should look to add a rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the slider for device battery, I saw a common problem: all the text around was moving when the number is changing.
So, for fix this, I added a font modifier with
monospacedDigit()in the Apple's documentation it is saying:Returns: A font that uses fixed-width numeric characters.Before the patch
Screen.Recording.2023-11-28.at.21.41.22.mov
After the patch
Screen.Recording.2023-11-28.at.21.38.18.mov
All text is only moving when the slider value goes from 9 to 10 and 99 to 100.
I thought to add animation as the one on the Apple Watch but it is too much for a developer software.
Access control
I declared method on the view as private for being more comprehensive by the compilator and maybe win some milliseconds at build time.
If you see something to improve let me know about it.