Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve notebook loading speed #178

Closed
jchendy opened this issue Apr 23, 2014 · 4 comments
Closed

Improve notebook loading speed #178

jchendy opened this issue Apr 23, 2014 · 4 comments
Assignees
@scottdraves
Labels
Enhancement Notebook Extension

Comments

@jchendy
Copy link

jchendy commented Apr 23, 2014

Try a large notebook such as https://raw.githubusercontent.com/gumption/Python_for_Data_Science/master/Python_for_Data_Science_all.ipynb

In Beaker, it takes ~45 seconds before anything appears and another 45 seconds before the loading is fully complete.

For comparison, IPython loads the whole thing in ~12 seconds.
@melmac48 melmac48 added this to the version 1.0 milestone Jun 15, 2014
@scottdraves scottdraves modified the milestones: version 1.0, version 2.0 Aug 29, 2014
@samccone samccone mentioned this issue May 4, 2015
Closed
samccone added a commit that referenced this issue May 14, 2015
@samccone
Lazily instantiate codemirror instances
462e592 
By taking advantage of the fact that a user can not interact
with codemirror instance until they are in the viewport, we can be
smart and only set the codemirror editors up once a user scrolls them into view.

For small notebooks this change has a limited impact, however for large
notebooks with 100s of code cells this change results in a significant
performance boost to the application, especially in the initial time to
render metric for notebooks.

ref #1546
Fixes #178
@samccone samccone mentioned this issue May 14, 2015
Merged
samccone added a commit that referenced this issue May 15, 2015
@samccone
Lazily instantiate codemirror instances
0490f67 
By taking advantage of the fact that a user can not interact
with codemirror instance until they are in the viewport, we can be
smart and only set the codemirror editors up once a user scrolls them into view.

For small notebooks this change has a limited impact, however for large
notebooks with 100s of code cells this change results in a significant
performance boost to the application, especially in the initial time to
render metric for notebooks.

ref #1546
Fixes #178
@scottdraves
Copy link
Contributor

not there yet

@scottdraves scottdraves reopened this May 18, 2015
@samccone
Copy link

@jchendy Would love to to have some feedback on how this "feels" now with the new fix that just landed

@scottdraves scottdraves modified the milestones: v1.5, v2.0 Aug 30, 2015
@scottdraves
Copy link
Contributor

we made some improvements on this front, need to keep working on it.

@scottdraves
Copy link
Contributor

dup of #2336

scottdraves pushed a commit that referenced this issue Mar 29, 2017
@scottdraves
adding git ignoe foe Eclipse (#178)
357343c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottdraves scottdraves

Labels
Enhancement Notebook Extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samccone @scottdraves @jchendy @melmac48