Dynamic assetPrefix via next runtime configuration utils #44
Conversation
|
bump |
| publicRuntimeConfig: Object.assign({}, nextConfig.publicRuntimeConfig, { | ||
| nextImagesAssetPrefix: nextConfig.assetPrefix | ||
| }), |
There was a problem hiding this comment.
Can't we move it to line 8? There we are initializing all configuration options.
There was a problem hiding this comment.
Unfortunately we can't move it from here because webpack part of next config is only used during build time. If you are in production "serve mode" aka next start webpack method wouldn't be called so root publicRuntimeConfig would not be touched.
| @@ -1,5 +1,8 @@ | |||
| module.exports = (nextConfig = {}) => { | |||
| return Object.assign({}, nextConfig, { | |||
| publicRuntimeConfig: Object.assign({}, nextConfig.publicRuntimeConfig, { | |||
| nextImagesAssetPrefix: nextConfig.assetPrefix | |||
There was a problem hiding this comment.
What's the difference between assetPrefix and nextImagesAssetPrefix ?
There was a problem hiding this comment.
nextConfig.assetPrefix is a runtime configuration value which can be used to set asset prefix of js bundles and other asset files. (https://nextjs.org/docs/api-reference/next.config.js/cdn-support-with-asset-prefix) According to official next.js docs it is only used internally by next and it is not accessible. That's why we need to expose it explicitly in publicRuntimeConfig so we can access it confidently on server side and client side too.
Since users could define their own public runtime configuration I thought we shouldn't call it simply "assetPrefix" because maybe we override a user defined config variable. So I ended up using a "namespaced" variable name.
|
@peter-jozsa Could you also update the readme please so that we know how to use the new feature? |
peter-jozsa
force-pushed
the
feature/dynamic-asset-prefix
branch
from
571be1d to
e7c1eda
Compare
|
As I checked availability of runtime configuration feature I saw it is only available starting from Next.js v6, is that a problem? Maybe this dynamic asset prefix feature should be opt-in since it will change transpiled image paths for everyone, what do you think? |
@peter-jozsa Let me check that after working hours. Will come back to you soon. |
Aims to implement support for runtime configurable asset prefixes in next-images package which was previously mentioned in #12