Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split BBANDS std into indiv upper and lower values #814

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

singhay
Copy link

@singhay singhay commented Jul 20, 2024

Original TA-lib offers option to have separate standard deviations for upper and lower bands. See https://github.com/TA-Lib/ta-lib/blob/main/src/ta_func/ta_BBANDS.c#L151

@twopirllc
Copy link
Owner

Hi @singhay,

Looks good on first glance. Thanks for updating the development version and resubmitting. 😎

Have any overall thoughts on the development version?

KJ

@singhay
Copy link
Author

singhay commented Jul 22, 2024

Hi KJ,

First of all, a phenomenal job maintaining this project. I know pace is slow, but little progress is still progress especially such few contributors. I've just started using the library so I'll keep contributing as work comes.

Meanwhile, what is your release cycle ? The dev branch is like ~300 commits behind, alot of folks are missing out on the good stuff.

Cheers 🍻 ,
Ayush

@twopirllc
Copy link
Owner

@singhay

First of all, a phenomenal job maintaining this project. I know pace is slow, but little progress is still progress especially such few contributors. I've just started using the library so I'll keep contributing as work comes.

Thanks. Any help is appreciated.

Meanwhile, what is your release cycle ? The dev branch is like ~300 commits behind, alot of folks are missing out on the good stuff.

On my screen, development is ~375 commits "ahead" of main. I guess it's the "behind" for a repo fork. 🤷🏼‍♂️ It's not in a cycle yet. Just some objectives to complete. For the most part, they are:

  • Numpy/Numba implementations of core moving averages and other popular indicators (especially loop based indicators) as well as rewrite slow indicators like qqe, alligator, etc if possible
  • Complete remaining Hilbert Transform indicators from TA Lib
  • Clean up or make new examples
  • Necessary PRs

Yeah, they are missing out on the good stuff. 🤷🏼‍♂️

KJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants