Add-on works for Ember Engines #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsmanuel
reviewed
Mar 27, 2017
|
|
||
| This is an experimental component that will add `background-image` style attribute to a component's `div`. It also | ||
| sets `min-height` attribute to `270px` so the image is visible. You should be able to overwrite it by using `lazy-background-image` class. | ||
| This README outlines the details of collaborating on this Ember addon. |
There was a problem hiding this comment.
The readme should probably stay the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add-on didn't work when we applied it to our Ember Engine (https://github.com/ember-engines/ember-engines). We updated it to work with newer versions of its dependencies, and pruned some stuff that was no longer needed and found that it now works in our Ember Engine.