Fix Redpanda tests #233
Merged
Fix Redpanda tests #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! I spent a while going through the github actions docs to try to find how to specify flags. Oh well! My next step was to see if just exposing the brokers would work in an env var, but it was late and I didn't know which env var to use at the time. This is awesome! |
|
You're very welcome! Glad I was able to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @twmb, thanks for the nudge :) I think this might just suffice.
Technically, the Docker command should look smth like this, I think (or at least that's what I've been cargo-culting for a while):
docker run --rm -p9092:9092 docker.vectorized.io/vectorized/redpanda:latest start --default-log-level=debug --smp 1 --reserve-memory 0M --overprovisioned --set redpanda.enable_transactions=true --kafka-addr 0.0.0.0:9092 --advertise-kafka-addr redpanda:9092, but GitHub Actions doesn't allow users to overwrite the DockerCMDyet, which is a very weird omission IMHO.