fixup kraft #224
Merged
fixup kraft #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See large comment. For #223.
Single-broker localhost kraft testing shows this error being returned **much** more frequently. Rather than having a 5s timeout, we now continue until the input context is canceled. This largely affects ending a transaction. We also improve the locking situation in one area. It's a bit ugly, but the solution is better than unlocking directly at every return site. For #223.
If a topic is deleted while being consumed, brokers will suddently return UNKNOWN_TOPIC_OR_PARTITION. This error is retriable and the partition is internally stripped. This would cause a fetch to finish immediately and re-fetch, which would spin. We now backoff if all partitions are stripped.
Kraft sometimes returns UNKNOWN_TOPIC_OR_PARTITION for a while even after it replies to a create topics request with success. We now retry these errors forever. Also, something about Kraft sometimes hangs when transitioning transaction states. We need RequireStableFetchOffsets to ensure our tests do not fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges #223 and adds a bunch of preceding commits that should address test failures.