Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -j (--json-pretty) option #130

Merged
merged 6 commits into from
Dec 16, 2019

Conversation

smaeda-ks
Copy link
Collaborator

@smaeda-ks smaeda-ks commented Dec 11, 2019

so users don't need to install jq just to format output.

@smaeda-ks smaeda-ks self-assigned this Dec 11, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 88.388% when pulling eeece0a on smaeda-ks:smaeda-ks/json-pretty into 03984a2 on twitter:master.

@coveralls
Copy link

coveralls commented Dec 11, 2019

Coverage Status

Coverage decreased (-0.01%) to 88.639% when pulling 146b8d4 on smaeda-ks:smaeda-ks/json-pretty into d082264 on twitter:master.

@smaeda-ks smaeda-ks requested a review from a team December 11, 2019 17:51
not all machines have the "TMPDIR" env variable set by default (e.g., Chrome OS) and hence Minitest actually removes user's "~/.twurlrc" file if the "TMPDIR" is not set. To remediate this, override the directory path in case if it's missing so running tests don't remove the user's file by accident.
@smaeda-ks smaeda-ks force-pushed the smaeda-ks/json-pretty branch from 118a4db to 7f0f5b1 Compare December 13, 2019 00:43
remove outdated info and use Markdown
@smaeda-ks smaeda-ks force-pushed the smaeda-ks/json-pretty branch from 589f0a2 to e378c75 Compare December 13, 2019 17:45
@smaeda-ks smaeda-ks added this to the Target v0.9.5 milestone Dec 15, 2019
@smaeda-ks smaeda-ks merged commit f81ec26 into twitter:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants