redis script command support #677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4096
reviewed
Jan 4, 2023
| { | ||
| struct server *server; | ||
| uint32_t idx; | ||
|
|
||
| idx = server_pool_idx(pool, key, keylen); | ||
| if (r->type == MSG_REQ_REDIS_SCRIPT) { | ||
| idx = r->redis_script_idx; |
There was a problem hiding this comment.
Add a member named server_index in struct msg. If the value is >=0, use msg->server_index as target server index. In this way, we don't need redis_script_idx and scan_server_idx at all.
| @@ -2945,10 +2982,97 @@ redis_fragment_argx(struct msg *r, uint32_t nserver, struct msg_tqh *frag_msgq, | |||
| return NC_OK; | |||
| } | |||
|
|
|||
| static rstatus_t redis_fragment_script(struct msg *r, struct msg_tqh *frag_msgq) { | |||
There was a problem hiding this comment.
If we can implement a function redis_fragment_broadcast which can broadcast a request to all servers, we can implement broadcast commands like DBSIZE, FLUSHALL easily. What I mean is this function is not general enough, which can only handle SCRIPT command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
redis script command not support.
Solution
Send the script command to all Redis servers for execution, and get one of the results and return it to the user client.
Result