Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow exists can variodic #388

Closed
wants to merge 2 commits into from
Closed

Conversation

charsyam
Copy link
Contributor

today, redis changed exists command can be variodic

request> exists ab a c
response> :3

but this feature just is in unstable.
@manjuraj Does twemproxy prefer to follow unstable branch of redis ? or stable branch?

@manjuraj
Copy link
Collaborator

I think we should wait for the command to be supported in stable branch before supporting them in twemproxy.

@charsyam
Copy link
Contributor Author

@manjuraj Yes, I agree with you.That's why I asked you about it :)

@charsyam
Copy link
Contributor Author

@manjuraj Redis 3.0.3 is out. and It contains variadic exists.
so it's time to merge this feature :)

@charsyam
Copy link
Contributor Author

@manjuraj Please review this :)
(and I just rebase this. not code changed.)
I think we have a problem about current CI testing.

@charsyam
Copy link
Contributor Author

charsyam commented Dec 3, 2015

@manjuraj ping Redis already contains variodic :)

@charsyam
Copy link
Contributor Author

@manjuraj ping

@charsyam
Copy link
Contributor Author

ping @manjuraj

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


clark.kang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TysonAndre
Copy link
Collaborator

#599 implements support for many newer redis commands, including this change to exists - I implemented it the same way without seeing this old pr

@TysonAndre
Copy link
Collaborator

#599 implements support for many newer redis commands, including this change to exists - I implemented it the same way without seeing this old pr

I was added as an external collaborator this week - #599 was merged.

@TysonAndre TysonAndre closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants