Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Robust handling server failure feature doesn't work when server_failure_limit is higher than 1 #126

Closed
charsyam opened this issue Jun 25, 2013 · 0 comments

Comments

@charsyam
Copy link
Contributor

@hrishimantri reported this:

  1. There are 2 redis instances running on two different boxes
  2. Twemproxy is installed on a client box which talks to these two boxes
  3. The twemproxy configuration is as pointed in Robust hash ring failure retry mechanism #29
  4. I use a Jedis Client to talk to Redis via twemproxy

Can you please go ahead and test these scenarios :
Testcase 1) Both the redis instances are up and running (twemp works fine)

Testcase 2) Stop Redis instance running on one of the box and then check if the request goes to the other slave where REDIS is up and running. If the failure_limit is set to 2 in the twemproxy conf then the node fails to be ejected. Though the Node gets ejected when the failure_limit is set to 1 and the request is then routed to the other slave.

Testcase 3) Restart the redis instance stopped in Testcase 2. The node should get restored and the requests should again be distributed randomly amongst the two slaves.

Testcase 1 and Testcase 3 work fine but Testcase 2 fails to work on failure_limit set to 2. Can you please retest this at your side ?

charsyam added a commit to charsyam/twemproxy that referenced this issue Jun 25, 2013
Applying robush hash ring failure into random and modula

Fix issue twitter#126
charsyam added a commit to charsyam/twemproxy that referenced this issue Jul 8, 2013
Applying robush hash ring failure into random and modula

Fix issue twitter#126

Fix: issue twitter#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant