Convert all laws to take Equiv instances, deprecate Equiv versions #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 80.31% (diff: 100%)@@ develop #595 diff @@
==========================================
Files 114 114
Lines 4994 4932 -62
Methods 4570 4506 -64
Messages 0 0
Branches 423 425 +2
==========================================
- Hits 3990 3961 -29
+ Misses 1004 971 -33
Partials 0 0
|
sritchie
force-pushed
the
sritchie/laws_equiv
branch
from
7fae938
to
a352a8a
Compare
|
Holy shit... those jvm opts dropped the build time from 40something minutes to 7 minutes on the |
|
@ianoc looks like these started running out of permgen space. Probably need to redo them one at a time. |
|
@sritchie Yeah looks like that. Lets not worry about it in this PR. The last one failed though. is that test reasonably flaky? |
|
Thanks for running the tests you did btw! |
|
@ianoc ah, yes, that one is, and we have an issue for it, I believe. kicking it off again |
|
here we go: #508 |
|
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all laws (and all tests!) to take Equiv instances by default. This is a binary-incompatible change, but in functions that take lots of implicit arguments that shouldn't be passed by default anyway.
All
LawsEquivversions have a deprecation warning and point to the actualLaws.This also adds
.jvmoptsto, hopefully, speed up the build.