Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using private _PY3 constant from Twisted, since it's now been deleted #288

Closed
glyph opened this issue Aug 25, 2020 · 3 comments
Closed

stop using private _PY3 constant from Twisted, since it's now been deleted #288

glyph opened this issue Aug 25, 2020 · 3 comments

Comments

@glyph
Copy link
Member

glyph commented Aug 25, 2020

We should really get this done before a new release of Twisted goes out.
@altendky
Copy link
Member

altendky commented Sep 7, 2020

Like, drop py2 support? Or just reimplement the constants inside treq.

@graingert
Copy link
Member

@altendky https://github.com/twisted/treq/blob/master/setup.py#L34

altendky added a commit to altendky/treq that referenced this issue Sep 7, 2020
@altendky
Use six.PY3 instead of twisted.python.compat._PY3
9e864e5 
twisted#288
@altendky altendky mentioned this issue Sep 7, 2020
Merged
@twm
Copy link
Contributor

twm commented Sep 9, 2020

Closing via #290. Thanks all!

@twm twm closed this as completed Sep 9, 2020
@richvdh richvdh mentioned this issue Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@twm @graingert @altendky @glyph