Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --pyproject option to towncrier.check #127

Merged
merged 5 commits into from
Sep 6, 2018

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Sep 5, 2018

Allows for a work-around for #123

@codecov-io
Copy link

codecov-io commented Sep 5, 2018

Codecov Report

Merging #127 into master will increase coverage by 0.09%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   93.25%   93.35%   +0.09%     
==========================================
  Files          15       15              
  Lines         623      632       +9     
  Branches       61       64       +3     
==========================================
+ Hits          581      590       +9     
  Misses         26       26              
  Partials       16       16
Impacted Files Coverage Δ
src/towncrier/check.py 93.33% <100%> (+0.47%) ⬆️
src/towncrier/test/test_check.py 100% <100%> (ø) ⬆️
src/towncrier/_settings.py 76.47% <80%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d600a8...baabb88. Read the comment docs.

@hawkowl
Copy link
Member

hawkowl commented Sep 6, 2018

thanks @exarkun

@hawkowl hawkowl merged commit 9e1b11e into twisted:master Sep 6, 2018
@exarkun exarkun deleted the 123.pyprojecttoml-option branch April 30, 2019 13:11
@dstansby
Copy link
Contributor

Would it be possible to add this as a command line option too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants