Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change ObsoleteException to inherit from Exception instead of BaseException #490

Merged
merged 1 commit into from
Nov 1, 2019
Merged

fix: Change ObsoleteException to inherit from Exception instead of BaseException #490

merged 1 commit into from
Nov 1, 2019

Conversation

fefi95
Copy link
Contributor

@fefi95 fefi95 commented Oct 31, 2019

Related to #426 - Do not inherit from BaseException

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@childish-sambino childish-sambino changed the title Changed the BaseException to Exception fix: Change ObsoleteException to inherit from Exception instead of BaseException Nov 1, 2019
childish-sambino
childish-sambino approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@childish-sambino childish-sambino merged commit 65f6c9f into twilio:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fefi95 @childish-sambino