Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove socks dependency #484

Merged

Conversation

Kerl1310
Copy link
Contributor

@Kerl1310 Kerl1310 commented Oct 15, 2019

Fixes #464 - Removes PySocks dependency

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this package without pysocks for a while.
c.f. https://build.opensuse.org/package/show/home:jayvdb:django/python-twilio in the .spec I remove it with sed

@childish-sambino
Copy link
Contributor

Just for reference, looks like this commit removed the socks usage: dc0df9f#diff-28594bd98de1243a52cb6747d8ae8bba

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PySocks dependency
3 participants