Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook validation with array parameter sorting Fixes #722 #723

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

robbie-terazo
Copy link
Contributor

@robbie-terazo robbie-terazo commented Jan 16, 2022

Fixes #722

Occasionally, sorting of an array parameter will put those parameters in a different order than when the signature was generated on the server. Establishing a sort order for both keys and values of array parameters ensures the same signature is generated when the array values appear in a different order.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Thanks for the fix!

@childish-sambino childish-sambino merged commit f049f5c into twilio:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twilio webhook signature validation can return false negative when parameters with arrays are passed
2 participants