fix: updated RequestClient to handle proxy from default PROXY_HOST env var #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @childish-sambino is there anything else required for this? |
|
It's on my list of items to review. |
childish-sambino
changed the title
| @@ -41,7 +40,9 @@ RequestClient.prototype.request = function(opts) { | |||
| var deferred = Q.defer(); | |||
| var headers = opts.headers || {}; | |||
|
|
|||
| if (!headers.Connection && !headers.connection) { | |||
| if (!headers.Connection && !headers.connection && opts.forever) { | |||
| headers.Connection = 'keep-alive'; | |||
There was a problem hiding this comment.
nit: headers.Connection = opts.forever ? 'keep-alive' : 'close';
There was a problem hiding this comment.
Hi. Apologies. Not following. NIT?
I think you are suggesting there is an alternate better approach here?
There was a problem hiding this comment.
Just suggesting a less-verbose replacement that's functionally equivalent.
childish-sambino
approved these changes
Sep 17, 2020
| @@ -41,7 +40,9 @@ RequestClient.prototype.request = function(opts) { | |||
| var deferred = Q.defer(); | |||
| var headers = opts.headers || {}; | |||
|
|
|||
| if (!headers.Connection && !headers.connection) { | |||
| if (!headers.Connection && !headers.connection && opts.forever) { | |||
| headers.Connection = 'keep-alive'; | |||
There was a problem hiding this comment.
Just suggesting a less-verbose replacement that's functionally equivalent.
|
Hi. Just checking in if this can be merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336
Description:
This fix updates the RequestClient to look at the default PROXY_HOST environment variable. It retains all original options however moves the keep-alive into the Connection header. Removes the http.Agent and https.Agent and replaces with the https-proxy-agent extension to handle the proxy variable. Additionally as mentioned in the Axios issues set the proxy to false (Axios issue reference: axios/axios#2072).
This has been tested in a simple node request. End users do not have to provide any additional information when calling Twilio for a client and as such has no breaking change.
Test Code:
Taken from https://www.twilio.com/docs/sms/tutorials/how-to-send-sms-messages-node-js?code-sample=code-send-an-sms-using-the-programmable-sms-api&code-language=Node.js&code-sdk-version=3.x
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.