Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign default value to twilioHeader during validation #446

Merged
merged 5 commits into from
May 16, 2019
Merged

Assign default value to twilioHeader during validation #446

merged 5 commits into from
May 16, 2019

Conversation

mniehe
Copy link
Contributor

@mniehe mniehe commented May 7, 2019

Adds a sensible default to twilioHeader if it's undefined during validation.

Closes #445

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

childish-sambino
childish-sambino suggested changes May 13, 2019
View reviewed changes
spec/validation.spec.js Outdated Show resolved Hide resolved
@childish-sambino childish-sambino merged commit 5dbef34 into twilio:master May 16, 2019
@khalilchoudhry khalilchoudhry mentioned this pull request Jun 21, 2019
Merged
1 task
@childish-sambino childish-sambino added the type: bug bug in the library label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined twilio header causing exception during validation
2 participants
@mniehe @childish-sambino