chore: update status pattern #4110
Open
+508
−322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0643cb2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0643cb2:
|
Paste
|
||||||||||||||||||||||||
| Project |
Paste
|
| Run status |
|
| Run duration | 02m 29s |
| Commit |
|
| Committer | “nora |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
serifluous
requested review from
serifluous
and removed request for
roxanagomez
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
serifluous
reviewed
Oct 16, 2024
nkrantz
force-pushed
the
chore/status-pattern-update
branch
from
394d15e
to
0643cb2
Compare
dosubot
bot
added
size:XL
serifluous
reviewed
Oct 17, 2024
| @@ -154,7 +182,7 @@ Non-text status indicators (such as icons or status dots) should be paired with | |||
| possible and should always be given a `title` to give context and meaning to the icon or shape. | |||
| Check out the [icon usage guidelines](/components/icon/usage-guidelines) for more detailed accessibility information. | |||
|
|
|||
| ## Variations | |||
| ## Status types | |||
|
|
|||
| ### Process status | |||
|
|
|||
There was a problem hiding this comment.
Update the text here to just be:
Process statuses indicate an object’s progress through a set of stages. Process statuses should always be paired with text.
serifluous
reviewed
Oct 17, 2024
Comment on lines
+218
to
+220
| - Otherwise, use the default [Status Badge](/components/status-badge). | ||
| Placement of the status in a Table should depend on the importance of the status to the given user flow and should be tested with users. | ||
| For statuses that are not as critical to a user’s workflow, use [plain text statuses](#plain-text-status). |
There was a problem hiding this comment.
Suggested change
| - Otherwise, use the default [Status Badge](/components/status-badge). | |
| Placement of the status in a Table should depend on the importance of the status to the given user flow and should be tested with users. | |
| For statuses that are not as critical to a user’s workflow, use [plain text statuses](#plain-text-status). | |
| - Otherwise, use the default [Status Badge](/components/status-badge). | |
| Placement of the status in a Table should depend on the importance of the status to the given user flow and should be tested with users. | |
| For statuses that are not as critical to a user’s workflow, use [plain text statuses](#plain-text-status). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates doc: https://docs.google.com/document/d/1kDSWZrUBIR0ZrliM80_IjKCM8rMIDiISuxHTlQ-1xvs/edit?tab=t.0