-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(status-badge): add borderless size #4094
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ecd190f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ecd190f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Size Change: +101 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
Paste Run #8771
Run Properties:
|
Project |
Paste
|
Branch Review |
status-badge/borderless-size
|
Run status |
Passed #8771
|
Run duration | 02m 06s |
Commit |
ecd190f95e: feat(status-badge): add borderless size
|
Committer | “nora |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
67
|
View all changes introduced in this branch ↗︎ |
"@twilio-paste/core": minor | ||
--- | ||
|
||
[Status Badge] add new `size` value "borderless" which removes padding and border (box shadow) for a less stylized option of Status Badge for use in Tables and other crowded layouts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: great description
* Sets the size of the Status Badge | ||
* | ||
* @default "default" | ||
* @type {StatusBadgeVariants} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! c/p error
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ecd190f:
|
cf64b3a
to
451f396
Compare
451f396
to
cbd025e
Compare
cbd025e
to
ecd190f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Paste Run #8776
Run Properties:
|
Project |
Paste
|
Branch Review |
status-badge/borderless-size
|
Run status |
Passed #8776
|
Run duration | 06m 20s |
Commit |
46070f1ead ℹ️: Merge ecd190f95e772cb124c14aa59ebbbb185da70465 into 85a754571221b15f8986ea92a16f...
|
Committer | Nora Krantz |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
125
|
View all changes introduced in this branch ↗︎ |
Add
size="borderless"
to Status Badge. Update docs and stories.