-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio-group): add element customization #1936
Conversation
🦋 Changeset detectedLatest commit: d49a6dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: d49a6dd 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/61689a2cae077c0008f3a8f3 😎 Browse the preview: https://deploy-preview-1936--paste-theme-designer.netlify.app |
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: d49a6dd 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61689a2cb4240900072bb8a8 😎 Browse the preview: https://deploy-preview-1936--paste-docs.netlify.app |
Size Change: +115 B (0%) Total Size: 530 kB
ℹ️ View Unchanged
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d49a6dd:
|
packages/paste-core/components/checkbox/stories/customization.stories.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/radio-group/stories/customization.stories.tsx
Show resolved
Hide resolved
packages/paste-core/components/checkbox/src/CheckboxDisclaimer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs alignment on label text element name across both radio and checkbox
packages/paste-core/components/checkbox/stories/customization.stories.tsx
Outdated
Show resolved
Hide resolved
chore(radio-group): add changeset chore(radio-group): add customization to radio chore(radio-group): fix story state issue
chore(checkbox): update PropTypes to add element chore(checkbox): update changeset, PropTypes chore(checkbox): fix element name for Label Text
a905c9d
to
d49a6dd
Compare
Make the Radio and Radio Group components customizable