fix(toast): correctly handle custom ids what auto dismissing toasts #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). paste – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste/ia20mm066 paste-theme-designer – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste-theme-designer/ieg29tsmi |
🦋 Changeset detectedLatest commit: 9a56423 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a56423:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Size Change: +10 B (0%) Total Size: 513 kB
ℹ️ View Unchanged
|
richbachman
approved these changes
Feb 10, 2021
TheSisb
approved these changes
Feb 10, 2021
Merged
This was referenced Aug 4, 2023
This was referenced Dec 7, 2023
This was referenced Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this discussion #1175
When supplied with a custom ID a toast will not auto dismiss when using the useToaster hook.