Fix SIP Quickstart login issues #330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for admin password
Admin Page Error Handling/Messaging:CLI / Serverless plugin messaging:Password not changed from default:
Password doesn't meet complexity requirements
Functions / Console messaging:Password not changed from default
Password doesn't meet complexity requirements
Incorrect Password Error (403: Not authorized)
|
craigsdennis
suggested changes
Apr 29, 2022
|
@craigsdennis Ok! Made changes from your suggestions + added tests to add coverage to new admin-password-related functions! |
|
Hey @bld010 ! We're in the process of going through the backlog of PRs. Did you still need to merge this one? Looks like there's a conflict in package-lock.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should resolve issues #245 and #295
Admin password requirements are made obvious and require a change from "default" password before accessing the rest of the admin area.
Show and hide login errors on DOM.
Checklist
npm testlocally and it passed without errors.Related issues
#245 and #295