feat(gateway)!: Constructors take String, not Into<String>
#1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intened to land at the same time as `twilight_http::Client` constructor's got rewored in the same way.
github-actions
bot
added
c-gateway
zeylahellyer
approved these changes
Jan 22, 2022
vilgotf
changed the title
String, not Into<String>String, not Into<String>
7596ff
approved these changes
Jan 22, 2022
Erk-
approved these changes
Jan 22, 2022
itohatweb
approved these changes
Jan 22, 2022
7596ff
added a commit
that referenced
this pull request
Jan 23, 2022
Additions
Add `Information::{ratelimit_refill, ratelimit_requests}` to view how
much time until the shard ratelimiter resets and how many requests until
the next refill ([#1368] - [@itohatweb])
Add `ClusterBuilder::shard_presence`, which allows setting a custom
presence based on a shard's ID ([#1474] - [@7596ff]).
Changes
The `rustls` feature has been removed ([#1314] - [@Gelbpunkt]). Users
must manually select one of `rustls-native-roots` or
`rustls-webpki-roots`.
`{CommandErrorType, SendErrorType}::ExecutorShutDown` have been removed,
since they are no longer possible ([#1368] - [@itohatweb]).
No longer derive `Deserialize` and `Serialize` on `Information` ([#1368]
- [@itohatweb]).
The MSRV has been updated to 1.57 ([#1402] - [@zeylahellyer]).
The Rust edition has been updated to 2021 ([#1412] - [@vilgotf]).
Constructors that used to take `impl Into<String>` now simply accept a
`String` ([#1481] - [@vilgotf]).
[#1314]: #1314
[#1368]: #1368
[#1402]: #1402
[#1412]: #1412
[#1474]: #1474
[#1481]: #1481
[@7596ff]: https://github.com/7596ff
[@itohatweb]: https://github.com/itohatweb
[@Gelbpunkt]: https://github.com/Gelbpunkt
[@vilgotf]: https://github.com/vilgotf
[@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intened to land at the same time as
twilight_http::Clientconstructor's got reworked in the same way.