refactor(model)!: revert moving snowflake to model #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "refactor: add snowflake getters to `Id<T: Snowflake>` (#1332)", effectively moving the `Snowflake` trait back to `util`. The Snowflake trait isn't a model, it's a helper for some computations; the model crate otherwise has no other traits other than this one, and so it's unprecedented and its addition was a mistake. This reverts commit 540ee9a.
github-actions
bot
added
c-model
zeylahellyer
added
t-refactor
Signed-off-by: Zeyla Hellyer <[email protected]>
7596ff
previously requested changes
Jan 20, 2022
Erk-
approved these changes
Jan 22, 2022
7596ff
added a commit
that referenced
this pull request
Jan 23, 2022
Changes All types and method signatures have been updated to use the new `Id<T>` syntax ([#1260] - [@zeylahellyer]). The MSRV has been updated to 1.57 ([#1402] - [@zeylahellyer]). The Rust edition has been updated to 2021 ([#1412] - [@vilgotf]). Fixes Missing ID marker implementations have been added ([#1471] - [@zeylahellyer]). [#1260]: #1260 [#1402]: #1402 [#1412]: #1412 [#1471]: #1471 [@vilgotf]: https://github.com/vilgotf [@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "refactor: add snowflake getters to
Id<T: Snowflake>(#1332)", effectively moving theSnowflaketrait back toutil. The Snowflake trait isn't a model, it's a helper for some computations; the model crate otherwise has no other traits other than this one, and so it's unprecedented and its addition was a mistake.This reverts commit 540ee9a.