Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache)!: Seal UpdateCache #1431

Merged
merged 4 commits into from
Jan 14, 2022
Merged

feat(cache)!: Seal UpdateCache #1431

merged 4 commits into from
Jan 14, 2022

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Jan 8, 2022

As C-SEALED recommends, most Twilight's traits are already sealed.

As C-SEALED recommends, most Twilight's traits are already sealed.
@github-actions github-actions bot added c-cache Affects the cache crate m-breaking change Breaks the public API. labels Jan 8, 2022
@vilgotf vilgotf changed the title enhancement(cache)!: Seal UpdateCache feat(cache)!: Seal UpdateCache Jan 9, 2022
@github-actions github-actions bot added the t-feature Addition of a new feature label Jan 9, 2022
cache/in-memory/src/lib.rs Outdated Show resolved Hide resolved
cache/in-memory/src/lib.rs Outdated Show resolved Hide resolved
cache/in-memory/src/lib.rs Outdated Show resolved Hide resolved
cache/in-memory/src/lib.rs Show resolved Hide resolved
@vilgotf vilgotf requested a review from itohatweb January 13, 2022 21:03
@7596ff 7596ff merged commit e609cad into twilight-rs:next Jan 14, 2022
@vilgotf vilgotf deleted the enhancement/cache/seal-updatecache branch January 14, 2022 18:16
7596ff added a commit that referenced this pull request Jan 23, 2022
Changes

All types and method signatures have been updated to use the new `Id<T>` syntax
([#1260] - [@zeylahellyer]).

The MSRV has been updated to 1.57 ([#1402] - [@zeylahellyer]).

Methods that return an image hash, such as `CachedGuild::banner`, now return an
`ImageHash` instead of a string ([#1405] - [@zeylahellyer]).

The Rust edition has been updated to 2021 ([#1412] - [@vilgotf]).

`UpdateCache` trait is now sealed ([#1431] - [@vilgotf]).

[#1260]: #1260
[#1402]: #1402
[#1405]: #1405
[#1412]: #1412
[#1431]: #1431

[@vilgotf]: https://github.com/vilgotf
[@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-cache Affects the cache crate m-breaking change Breaks the public API. t-feature Addition of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants