Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lavalink: Node::connect fails due to missing header #1647

Closed
james7132 opened this issue Apr 2, 2022 · 0 comments · Fixed by #1666
Closed

lavalink: Node::connect fails due to missing header #1647

james7132 opened this issue Apr 2, 2022 · 0 comments · Fixed by #1666
Labels
c-lavalink Affects the lavalink crate t-bug Programming error in the library

Comments

@james7132
Copy link
Contributor

All of my Lavalink nodes are failing to connect to Lavalink servers. This is the warning that's showing up in the logs:

2022-04-02T09:08:04.664358251Z  WARN ThreadId(02) twilight_lavalink::node: failed to connect to node WebSocket protocol error: Missing, duplicated or incorrect header sec-websocket-key: <IP ADDRESS>

Seems to be very similar to snapview/tungstenite-rs#270 that resulted from changes in 0.17, and is coming from

twilight/lavalink/src/node.rs

Line 621 in 1d30cf1

let mut builder = Request::get(format!("ws://{}", state.address));
which does not include this required header.
@7596ff 7596ff added t-bug Programming error in the library c-lavalink Affects the lavalink crate labels Apr 2, 2022
7596ff added a commit that referenced this issue Apr 2, 2022
@7596ff
fix(lavalink): include Sec-WebSocket-Key header
b49ff82 
Add the missing header due to a regression in `tokio-tungstenite`.

Closes #1647.
@7596ff 7596ff mentioned this issue Apr 2, 2022
Merged
7596ff added a commit that referenced this issue Apr 15, 2022
@7596ff
fix(lavalink): include Sec-WebSocket-Key header (#1666)
e5fba58 
Add the missing header due to a regression in `tokio-tungstenite`.

Closes #1647.
@james7132 james7132 reopened this Jun 5, 2022
@james7132 james7132 mentioned this issue Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-lavalink Affects the lavalink crate t-bug Programming error in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lavalink): include Sec-WebSocket-Key header twilight-rs/twilight
2 participants
@7596ff @james7132