Rely on reflection to access null properties #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
array-cast-less
branch
from
940ea01 to
f023cec
Compare
stof
reviewed
Oct 29, 2024
nicolas-grekas
force-pushed
the
array-cast-less
branch
from
f023cec to
5e793c3
Compare
stof
reviewed
Oct 29, 2024
nicolas-grekas
force-pushed
the
array-cast-less
branch
from
5e793c3 to
e4eb3ce
Compare
fabpot
reviewed
Oct 29, 2024
nicolas-grekas
force-pushed
the
array-cast-less
branch
2 times, most recently
from
c186115 to
d8f39e6
Compare
|
PR updated with a simpler and more performant approach, that makes DateTimeInterface a special case (because it is). |
GromNaN
reviewed
Oct 31, 2024
nicolas-grekas
force-pushed
the
array-cast-less
branch
from
d8f39e6 to
aca2914
Compare
stof
reviewed
Oct 31, 2024
nicolas-grekas
force-pushed
the
array-cast-less
branch
2 times, most recently
from
5e1b6fe to
ca54737
Compare
fabpot
reviewed
Nov 1, 2024
nicolas-grekas
force-pushed
the
array-cast-less
branch
from
ca54737 to
6952a4a
Compare
nicolas-grekas
force-pushed
the
array-cast-less
branch
from
6952a4a to
5cd1ff1
Compare
|
Thank you @nicolas-grekas. |
gharlan
reviewed
Dec 4, 2024
| @@ -1642,7 +1642,7 @@ public static function getAttribute(Environment $env, Source $source, $object, $ | |||
|
|
|||
| // array | |||
| if (Template::METHOD_CALL !== $type) { | |||
| $arrayItem = \is_bool($item) || \is_float($item) ? (int) $item : $item; | |||
| $arrayItem = \is_bool($item) || \is_float($item) ? (int) $item : $item = (string) $item; | |||
There was a problem hiding this comment.
The string casting breaks my ArrayAccess object using objects as keys, when using myCollection[object] in twig.
There was a problem hiding this comment.
Arf. Can you please submit a fix as a PR together with a test case?
This was referenced Dec 4, 2024
Closed
fabpot
added a commit
that referenced
this pull request
Dec 10, 2024
This PR was merged into the 3.x branch. Discussion ---------- Fix ArrayAccess with objects as keys fixes #4476 The bug was introduced in 3.15 via #4425 (comment) Commits ------- 32a75b7 Fix ArrayAccess with objects as keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark like https://gist.github.com/arnaud-lb/c4235164fb41e11672aa670da8fa4fc7 (which were done for another use case but is still relevant here) prove that using reflection instead of array-casts is significantly faster for accessing properties.
Checking for dynamic properties is done with property_exists.