Fix sandbox for methods #1950

hason · 2015-12-30T10:06:52Z

Fixes:

Configure sandbox for method __call.
Call enabled method with name same as property.

stof · 2015-12-30T10:15:24Z

lib/Twig/Template.php

@@ -573,6 +576,10 @@ protected function getAttribute($object, $item, array $arguments = array(), $typ
            $method = (string) $item;
            $call = true;
        } else {
+            if (isset($propertySandboxException)) {
+                throw $propertySandboxException;


shouldn't this go after the $isDefinedTest condition ?

Thanks! Fixed.

hason force-pushed the policy branch from 2b416d8 to 159c7e8 Compare December 30, 2015 10:07

stof reviewed Dec 30, 2015
View reviewed changes

hason force-pushed the policy branch 2 times, most recently from e20380f to ebb14a3 Compare January 20, 2016 08:42

hason force-pushed the policy branch from ebb14a3 to 57742de Compare May 10, 2019 10:48

Add more test for sandbox

15aa49e

hason force-pushed the policy branch from 57742de to 006abe8 Compare January 25, 2021 14:39

Fix sandbox for methods

fb3f27c

hason force-pushed the policy branch from 006abe8 to fb3f27c Compare January 25, 2021 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sandbox for methods #1950

Fix sandbox for methods #1950

hason commented Dec 30, 2015 •

edited

Loading

stof Dec 30, 2015

hason Jan 25, 2021

Fix sandbox for methods #1950

Are you sure you want to change the base?

Fix sandbox for methods #1950

Conversation

hason commented Dec 30, 2015 • edited Loading

stof Dec 30, 2015

Choose a reason for hiding this comment

hason Jan 25, 2021

Choose a reason for hiding this comment

hason commented Dec 30, 2015 •

edited

Loading