Added support for foo.some_thing === foo.someThing #1299

hason · 2013-12-19T11:11:24Z

Alternative implementation of #934. Works well for methods, properties and array calls of objects with minimal performance impact. Results of twig benchmark (fabpot/twig-perf):

                               |       v1.12.3 |       v1.16.3 | origin/master | origin/methods | 
------------------------------------------------------------------------------------------------
empty                          |     13.5  0.0 |      8.8  0.0 |     14.4  0.0 |     20.5  0.0 | 
empty/B                        |      7.9  0.0 |     14.1  0.0 |     14.6  0.0 |     18.9  0.0 | 
simple_attribute               |     88.2  0.9 |     99.8  0.9 |     99.2  0.8 |     99.3  0.9 | 
simple_array_access            |    180.2  1.3 |    132.8  0.9 |    120.6  0.9 |    127.1  1.0 | 
simple_method_access           |     94.4  2.4 |     92.9  2.7 |    101.7  2.7 |    119.7  2.9 | 
simple_attribute_big_context/B |     90.5  0.9 |    101.3  0.9 |    100.5  1.0 |    116.1  1.3 | 
simple_variable                |    710.0  0.7 |    698.6  0.7 |    711.9  0.8 |    680.2  0.7 | 
simple_variable_big_context/B  |    702.2  1.3 |    668.3  1.3 |    795.9  1.2 |    674.3  1.2 | 
simple_foreach                 |     10.9  0.0 |     21.0  0.0 |     15.2  0.0 |     10.7  0.0 | 
simple_foreach/B               |     10.1  5.7 |     16.3  7.7 |      9.9  5.0 |     14.5  4.7 | 
empty_extends                  |      9.5  0.0 |     17.4  0.0 |     17.6  0.0 |     13.9  0.0 | 
empty_extends/B                |     16.1  0.0 |     17.5  0.0 |     10.2  0.0 |     22.6  0.0 | 
empty_include                  |     10.3  0.0 |     10.0  0.0 |     12.1  0.0 |      9.5  0.0 | 
empty_include/B                |     14.8  0.0 |     14.5  0.0 |     15.4  0.0 |     14.4  0.0 | 
standard                       |     22.1  0.0 |     12.6  0.0 |     12.9  0.0 |     14.0  0.0 | 
escaping                       |    101.8  1.2 |    110.9  1.2 |    107.5  0.8 |     99.2  1.0 |

simensen · 2014-01-16T14:41:51Z

Wow! This seems like it might be great. I don't know enough of the C code to know how well this is implemented. That is part of the reason I haven't had a chance to follow up on #934 yet. Thanks for running with this!

stof · 2014-01-16T15:31:49Z

ext/twig/twig.c

 	zend_property_info *pptr = (zend_property_info *) pDest;
 	APPLY_TSRMLS_FETCH();

-	if (!(pptr->flags & ZEND_ACC_PUBLIC) || (pptr->flags & ZEND_ACC_STATIC)) {
+	if ((pptr->flags & ZEND_ACC_PRIVATE) || (pptr->flags & ZEND_ACC_STATIC)) {


wouldn't this change cause some issues with protected ? Note that I'm not sure about my comment as I'm not a C developer

hason · 2015-01-21T09:45:39Z

@fabpot ping

This PR does not hurt performance #934 (comment) and works with properties and arrays #934 (comment)

fabpot · 2015-01-21T21:43:18Z

composer.json

@@ -27,7 +27,8 @@
        "forum": "https://groups.google.com/forum/#!forum/twig-users"
    },
    "require": {
-        "php": ">=5.2.4"
+        "php": ">=5.2.4",
+        "ext-pcre": "*"


I would remove this one.

fabpot · 2015-01-21T21:45:28Z

@tucksaun @jpauli Can you have a look at the C part of this PR?

fabpot · 2015-01-21T21:47:19Z

lib/Twig/Template.php

+        if (is_object($object)) {
+            $class = get_class($object);
+            if (!isset(self::$cache[$class])) {
+                self::$cache[$class] = $this->getCacheForClass($class);


for the non-debug mode, what about keeping this cache on disk? Would that makes things faster? It looks like there is a lot going on in the getCacheForClass() method and I cannot believe that it does not have any impacts on real-world templates.

Support for the cache may be added in another PR.

…ay calls

lsmith77 · 2016-09-27T07:42:57Z

can we give this PR some life again?

elnur · 2017-03-09T04:13:00Z

😞

fabpot · 2018-03-02T19:21:49Z

This PR was auto-closed because I've removed the master branch and this PR was based on master. I cannot reopen it unfortunately.

fabpot · 2018-03-02T19:24:40Z

Changing the base branch to 2.x worked :)

fabpot · 2019-02-15T02:55:36Z

This one never moved forward as we did not get feedback on the C implementation. I propose to rebase it on 2.x where we don't have the C extension.

hason · 2021-01-26T05:51:21Z

@fabpot The C extension in 1.x is no longer used. Should I update this PR on 1.x or 2.x?

xabbuh · 2021-01-26T09:33:11Z

@hason The C extension is gone.

hason mentioned this pull request Jan 16, 2014

[RFC] Support foo.some_thing === foo.someThing #934

Closed

stof reviewed Jan 16, 2014
View reviewed changes

stof mentioned this pull request Sep 30, 2014

Twig_String_Loader hick-up with variable names using underscores #1519

Closed

fabpot force-pushed the master branch from dff2085 to 8d9a00d Compare October 22, 2014 14:39

hason force-pushed the methods branch from db8557a to 9a1a760 Compare December 31, 2014 12:05

hason force-pushed the methods branch from 9a1a760 to 045d690 Compare January 21, 2015 09:22

fabpot reviewed Jan 21, 2015
View reviewed changes

hason added 4 commits January 23, 2015 11:22

Added method to receive cache for a class

bf5821b

Added support foo.some_thing === foo.someThing

6ed315a

Fixed accessing to underscore methods

cc48443

Added support foo.some_thing === foo.someThing for properties and arr…

0a4c21d

…ay calls

hason force-pushed the methods branch from 045d690 to 0a4c21d Compare January 23, 2015 10:31

hason mentioned this pull request Apr 25, 2015

array variable underscore symbol _ array.parent_id work like array.parentid #1676

Closed

hason mentioned this pull request Feb 18, 2016

Add better support for Twig coding conventions #1990

Closed

fabpot force-pushed the master branch from 8d31598 to 2bb25f5 Compare November 10, 2016 17:46

fabpot closed this Mar 2, 2018

fabpot changed the base branch from master to 2.x March 2, 2018 19:24

fabpot reopened this Mar 2, 2018

fabpot force-pushed the 2.x branch from 49c808a to fa8e07f Compare March 6, 2019 17:19

fabpot force-pushed the 2.x branch 3 times, most recently from c2a7ac3 to d997512 Compare May 1, 2019 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for foo.some_thing === foo.someThing #1299

Added support for foo.some_thing === foo.someThing #1299

hason commented Dec 19, 2013

simensen commented Jan 16, 2014

stof Jan 16, 2014

hason commented Jan 21, 2015

fabpot Jan 21, 2015

fabpot commented Jan 21, 2015

fabpot Jan 21, 2015

hason Feb 18, 2015

lsmith77 commented Sep 27, 2016

elnur commented Mar 9, 2017

fabpot commented Mar 2, 2018

fabpot commented Mar 2, 2018

fabpot commented Feb 15, 2019

hason commented Jan 26, 2021 •

edited

Loading

xabbuh commented Jan 26, 2021

Added support for foo.some_thing === foo.someThing #1299

Are you sure you want to change the base?

Added support for foo.some_thing === foo.someThing #1299

Conversation

hason commented Dec 19, 2013

simensen commented Jan 16, 2014

stof Jan 16, 2014

Choose a reason for hiding this comment

hason commented Jan 21, 2015

fabpot Jan 21, 2015

Choose a reason for hiding this comment

fabpot commented Jan 21, 2015

fabpot Jan 21, 2015

Choose a reason for hiding this comment

hason Feb 18, 2015

Choose a reason for hiding this comment

lsmith77 commented Sep 27, 2016

elnur commented Mar 9, 2017

fabpot commented Mar 2, 2018

fabpot commented Mar 2, 2018

fabpot commented Feb 15, 2019

hason commented Jan 26, 2021 • edited Loading

xabbuh commented Jan 26, 2021

hason commented Jan 26, 2021 •

edited

Loading